Use real RuntimeTables for non-imported tables in ctor-eval#8271
Draft
stevenfontanella wants to merge 1 commit intomainfrom
Draft
Use real RuntimeTables for non-imported tables in ctor-eval#8271stevenfontanella wants to merge 1 commit intomainfrom
stevenfontanella wants to merge 1 commit intomainfrom
Conversation
stevenfontanella
force-pushed
the
runtimetable-fix
branch
from
7280921 to
c4001da
Compare
stevenfontanella
force-pushed
the
runtimetable-fix
branch
from
c4001da to
f13b303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #8194 (comment).
Removes some complexity in wasm-interpeter.h since we no longer need to inject a factory function for creating tables (we instead always create a RealRuntimeTable). Also potentially allows more optimizations on non-imported tables in ctor-eval.